search

samuelneff / MimeTypeMap

Provides a huge dictionary of file extensions to mime types.
MIT License
625 stars 201 forks source link

Add Support for .NET Core 2.0 and Standard 2.0 #65

Closed jacksondaw closed 6 years ago

jacksondaw commented 6 years ago

Hi Samuel,

I am in the process of converting a project to .NET core so that I can run it cross platform and as a docker container. The only nuget that does not support .NET core is MimeTypeMap, so I have gone a head and converted it, in this pull request.

This solves issue #53.

It does not create a different solution and/or project file, because that is not necessary anymore.

I have attached an updated Nuget file, if you don't have a current environment to create one.

MimeTypeMap.1.0.3.zip

Let me know if you have any questions or are looking for help maintaing this repo?

Thank you, Jack

samuelneff commented 6 years ago

Jack,

Thanks for putting this together in a pull request. Merged!

I'll look into uploading the latest to NuGet now.

Sam

jacksondaw commented 6 years ago

Thank you!

jacksondaw commented 6 years ago

Oh, I forgot to mention you will need to unzip the nuget before uploading it. Github did not allow a .nupkg to be uploaded.

Let me know if you are having any issues.

spudcud commented 6 years ago

I just installed the 2.1.0 nuget package and it is giving me this warning when it pulls the project. It all works but it would be nice to not have a warning about this.

warning NU1701: Package 'MediaTypeMap 2.1.0' was restored using '.NETFramework,Version=v4.6.1' instead of the project target framework '.NETCoreApp,Version=v2.0'. This package may not be fully compatible with your project.

samuelneff commented 6 years ago

I don't own any of the three NuGet packages that were created from this source. I'm not able to update them.