search

samuelpordeus / vscode-elixir-test

Visual Studio Code extension to interact with elixir tests
MIT License
37 stars 36 forks source link

Default keybinding to run tests conflicts with built-in shortcut #48

Closed brainlid closed 4 years ago

brainlid commented 4 years ago

On Linux and Windows, the keyboard binding ctrl + shift + k is already mapped by default in VS Code as "Delete Line". I use this shortcut all the time. I'm on Linux.

I just installed the Elixir Test extension and it broke my keybinding.

Consider changing the default keybinding? Otherwise users have to know to re-map it.

samuelpordeus commented 4 years ago

@brainlid thanks for opening the issue, we should definitely change it.

brainlid commented 4 years ago

Looks like you guys fixed it! :heart:

brainlid commented 4 years ago

Sorry. My mistake. It's still an issue.

vsyrovat commented 4 years ago

It's true, by default combination Ctrl+Shift+K binded to "delete line", but there is not significant influence to work abilities because line deleting is also possible with Shift+Del.

focused commented 4 years ago

It's true, by default combination Ctrl+Shift+K binded to "delete line", but there is not significant influence to work abilities because line deleting is also possible with Shift+Del.

On macbook's keyboard there is a Shift+Backspace and it's binded to deleteLeft by default, to use Shift+Delete I need to press Fn key also, it's very inconvenient.

ricardoruwer commented 4 years ago

Feel free to open a PR -> https://github.com/samuelpordeus/vscode-elixir-test/blob/master/package.json#L58

brainlid commented 4 years ago

It's true, by default combination Ctrl+Shift+K binded to "delete line", but there is not significant influence to work abilities because line deleting is also possible with Shift+Del.

Shift+Del isn't a "delete line" it's a "cut". So it removes the line but modifies the copy buffer.