search

samuelpordeus / vscode-elixir-test

Visual Studio Code extension to interact with elixir tests
MIT License
37 stars 36 forks source link

Improve the template file on new test file. #53

Closed RoyalMist closed 4 years ago

RoyalMist commented 4 years ago

Hello I was thinking about adding this to the base template of a new file like so:

defmodule Hangman.RealTest do use ExUnit.Case doctest Hangman.Real alias Hangman.Real

end

RoyalMist commented 4 years ago

Hello @samuelpordeus so there are now two dialogs in a row hope this is ok for you,

samuelpordeus commented 4 years ago

@RoyalMist mmm... what is your opinion about it? Does it look bad?

RoyalMist commented 4 years ago

@RoyalMist mmm... what is your opinion about it? Does it look bad?

I propose to see it while using the feature. At least it can save time so I think it is ok :)

ricardoruwer commented 4 years ago

I'd say that 1 dialog is better 😄

RoyalMist commented 4 years ago

I'd say that 1 dialog is better 😄

Yes :) Maybe adding doctest by default is not harmfull since if the user did not add Doctest in the module it will have no effect wht do you think ?

Can I remove the dialog @samuelpordeus ?

samuelpordeus commented 4 years ago

@RoyalMist :shipit: 👍

samuelpordeus commented 4 years ago

@RoyalMist Thanks for the initiative and contribution! ❤️