Inclusion in the main repository

samuelpowell / LSL.jl

A Julia interface to the lab streaming layer library, liblsl

MIT License

3 stars 1 forks source link

Inclusion in the main repository #17

Open tstenner opened 4 years ago

tstenner commented 4 years ago

The main repository has all the official language bindings as submodules. I've looked over the code and if you think it's ready I think it'd be a good idea to have it in there (even though no one has asked for Julia bindings yet :-).

The semi-official policy is that the repository would have to be transferred to the labstreaminglayer organization (with you as an admin, of course) or have the labstreaminglayer organization as administrator in the repository.

samuelpowell commented 4 years ago

@tstenner this would be good. I think the code is very usable as it is, but I'l like to wait a little until we've had time to:

properly implement string streams
provider buffer streams for Julia structures (of non-ptr datatypes)
provide better integration with some of the Julia base interfaces for iteration, etc.
stress test
bulk out the unit tests
check on all platforms (including ARM)

So can we revisit this when I've made a bit more progress on the above?

samuelpowell commented 4 years ago

I'd also like to fix up the Windows x64 build. At the moment all platforms are cross-compiled (https://github.com/samuelpowell/LSLBuilder) on CI. This seems fine for everything apart from Windows x64 (builds fine, segfault at runtime), so at the moment the package replaces the cross-compiled library with an official build on this platform when it is installed. Probably related to the use of minGW, could be simple as lacking the right compiler defines, but will need some time to figure that out.