search

samuelpowell / Spinnaker.jl

A Julia interface to the FLIR/PointGrey Spinnaker SDK
MIT License
15 stars 7 forks source link

Add tests (local only, given need for camera) and enable use on MacOS (slight mod of #52) #53

Closed IanButterworth closed 4 years ago

IanButterworth commented 4 years ago

I thought I'd add some basic tests, given I often just want to try this on different cameras.

Currently these tests pass on my mono grasshopper3, but fail on its RGB equivalent. Not sure why yet.

Also, includes (a slightly modified) #52, so works with the new MacOS spinnaker SDK

samuelpowell commented 4 years ago

@ianshmean I agree on changes to #52 but adding tests which expect hardware will cause the package to fail under CI without a camera (including, e.g., PkgEvaluator runs). You could guard them with an environment variable or something if you so chose?

samuelpowell commented 4 years ago

Regarding RGB support, there's loads of things that could be wrong - I've only really considered mono cameras in the main interface.

IanButterworth commented 4 years ago

@samuelpowell Good points. I've made the requested changes. CI tests will exit early now, without loading Spinnaker.

I've also fixed a framerate issue where if the camera was set to auto framerate, framerate couldn't be changed. Note the addition of framerate!(cam) too, to set back to auto framerate.