search

samuelpowell / Spinnaker.jl

A Julia interface to the FLIR/PointGrey Spinnaker SDK
MIT License
15 stars 7 forks source link

More verbose node errors #66

Closed IanButterworth closed 4 years ago

IanButterworth commented 4 years ago

Attempt to fix #65

Makes it a bit easier to figure out what's going wrong when you get a Spinnaker SDK error: SPINNAKER_ERR_INVALID_HANDLE(-1006)

samuelpowell commented 4 years ago

Looks fine but I can't test it, I trust it works okay? Are you going to bump VERSION in this PR?

samuelpowell commented 4 years ago

You can merge and release?

IanButterworth commented 4 years ago

I've tested that this works in a "working" system, but I've not been able to construct a reliable error setup for catching the error state that would print within implemented(name, hNode), so that part is untested

IanButterworth commented 4 years ago

But even if it doesn't catch the error, it will throw(err) so should be ok

IanButterworth commented 4 years ago

I'll merge & release

samuelpowell commented 4 years ago

Yes that path looks safe

samuelpowell commented 4 years ago

Thanks @ianshmean

IanButterworth commented 4 years ago

Good thing you questioned that. I was missing an interpolation on the error message