search

samuelpowell / Spinnaker.jl

A Julia interface to the FLIR/PointGrey Spinnaker SDK
MIT License
15 stars 7 forks source link

move init to first usage of CameraList #89

Closed IanButterworth closed 1 year ago

IanButterworth commented 1 year ago

It's become bad practice to do anything other than load the julia package during package load. __init__() usage is recommended against.

Also, if Spinnaker was baked into a sysimage the previous __init__() warning logs were showing up during every subsequent precompilation job.

This should also help package load times.

I propose this is done in a patch bump as there shouldn't be any functional difference.

AFAICT CameraList() is a mandatory entry point for the package.

IanButterworth commented 1 year ago

@Octogonapus a review would be appreciated

IanButterworth commented 1 year ago

Test pass locally with a camera

     Testing Running tests...
Test Summary:      | Pass  Total  Time
Camera Interaction |    8      8  1.5s
     Testing Spinnaker tests passed