search

samuelpowell / Spinnaker.jl

A Julia interface to the FLIR/PointGrey Spinnaker SDK
MIT License
15 stars 7 forks source link

Fix Crash due to Duplicate Initialization of System #91

Closed Octogonapus closed 1 year ago

Octogonapus commented 1 year ago

init can now no longer initialize the global System more than once, which fixes the crash in #90. Added my MWE as a test.

Fixes #90.

IanButterworth commented 1 year ago

I don’t follow how the mwe would trigger the issue this fixes. If they are called async or on different threads I’d understand, for which this seems like a good idea to protect against.

IanButterworth commented 1 year ago

Oh, just seen the explanation in the issue.

Frustrating simple bug..

Thanks

Octogonapus commented 1 year ago

@IanButterworth It's explained briefly in #90 but the full explanation is in our internal repo

IanButterworth commented 1 year ago

New version registering here https://github.com/JuliaRegistries/General/pull/89038