search

samuelstroschein / inlang-plugin-json

inlang plugin to parse and serialize json resources
MIT License
9 stars 3 forks source link

machine translation is not working #26

Closed jannesblobel closed 1 year ago

jannesblobel commented 1 year ago

I tried to translate missing messages in a repo. And realized the machine translation was not working. I am unsure if this is a plugin problem or an inlang core issue. Please let me know if I should open this issue in the main repo. https://inlang.com/editor/github.com/jannesblobel/AFFiNE

https://www.loom.com/share/e6965b47bbd541c68583ddef9e00a534 @NilsJacobsen @NiklasBuchfink I can't assign you :( Reproduce:

  1. Open this repo https://inlang.com/editor/github.com/jannesblobel/AFFiNE
  2. until the empty messages come
  3. click on "machine translate"
NiklasBuchfink commented 1 year ago

I couldn't reproduce this issue with the link provided.

  1. Forked the repo
  2. Commited all german translation by using machine translate
  3. Pushed everything to my fork
jannesblobel commented 1 year ago

Ok, this is weird. I tried again and have the same issues :/ I will investigate in the afternoon

Maybe that's because I used Safarie

NiklasBuchfink commented 1 year ago

Btw, you can use the new plugin-i18next for that repository.

jannesblobel commented 1 year ago

Should we ask such a question in the Issues Template inlang/inlang? What browser was used?

NilsJacobsen commented 1 year ago

I think that decisions will be a lot easier for the users when we have the plugin registry

NiklasBuchfink commented 1 year ago

@jannesblobel Is this still an issue? Otherwise this can be closed.

jannesblobel commented 1 year ago

Frankly speaking, yes it is still exists https://www.loom.com/share/c728a50975424dc09208c6e2538b8af1

NiklasBuchfink commented 1 year ago

I still can't reproduce it.

It works on my machine

every programmer ever

Let's do it the way you mentioned in the Loom. Close it for now, and if this becomes a problem again, we'll take a closer look