samuelthomas2774 / nxapi

Nintendo Switch Online/Parental Controls app APIs. Show your Nintendo Switch presence in Discord, get friend notifications on desktop, and download and access SplatNet 2, NookLink, SplatNet 3 and Parental Controls data. Mirror of https://gitlab.fancy.org.uk/samuel/nxapi.git.
GNU Affero General Public License v3.0
413 stars 34 forks source link

windows scroll bar hell #24

Closed oscie57 closed 1 year ago

oscie57 commented 1 year ago

i put this on the discord but i thought it'd be a good idea to put it here to make tracking of this issue easier.

on windows, game-specific services have alot of scrollbars that look super ugly in use, for example: image

as mentioned by two people, using css would probably make it look alot better.


also a slight suggestion, would hiding the "file, edit, etc" bar be a possibility? it seems quite unnecessary to be there if im honest, and removing it shouldnt be too much of a hassle.

samuelthomas2774 commented 1 year ago

I've had a look at the scrollers in SplatNet 3 and have hidden some of them. This could easily break (like the refresh handling) but it shouldn't make the app unusable (just the extra scrollbars will reappear), which is why I wasn't sure it would be possible to do this safely. (I think there might still be some pages where additional scroll bars are visible, for example I haven't touched any scrollers with pull-to-refresh in case changing the scrolling options could break that.)

Screenshot 2022-09-20 at 21 00 58

(This also applies to macOS without a trackpad or depending on user preferences, and to Linux, again depending on desktop environment and possibly preferences.)

I've hidden the menu bar as well, thanks for reminding me again.

oscie57 commented 1 year ago

oh awesome!

samuelthomas2774 commented 1 year ago

Added in v1.5.0.

oscie57 commented 1 year ago

it is still in some places

image image

samuelthomas2774 commented 1 year ago

A few pages (such as those ones) have nested sliding/pull-to-refresh scrollers; I haven't changed those intentionally just in case it affects anything to do with that functionality (or in an update).

oscie57 commented 1 year ago

could you make them less intrusive?

oscie57 commented 1 year ago

did you see this? unsure what the lack of response means lmao

samuelthomas2774 commented 1 year ago

The scroll bars can be themed (https://developer.mozilla.org/en-US/docs/Web/CSS/::-webkit-scrollbar) but I'd prefer to just keep the native ones for now as that replaces them entirely.