search

samuelvanderwaal / metaboss

The Metaplex NFT-standard Swiss Army Knife tool.
Apache License 2.0
691 stars 220 forks source link

Sign all command broken #104

Closed AnderUstarroz closed 2 years ago

AnderUstarroz commented 2 years ago

Something seems to be wrong with the latest version (Metaboss v0.5.1). I have installed the latest via cargo install metaboss:

    Replaced package `metaboss v0.4.0-beta (~/metaboss)` with `metaboss v0.5.1 (~/metaboss)` (executable `metaboss`)

But now when if I try to sign my NFT:

metaboss sign all -k ~/.config/solana/my_key.json --candy-machine-id MY_CM2_ID --v2

I got the following error: error: Found argument '--candy-machine-id' which wasn't expected, or isn't valid in this context and if I remove that param --candy-machine-id I got this:

Error: Must specify exactly one of --candy-machine-id or --mint-data-dir
AnderUstarroz commented 2 years ago

function seems to be changed, now uses the param --creator where I suppose we need to add the first Creator address of an NFT created by the CM2. So I think this issue should be just about updating the docs.

samuelvanderwaal commented 2 years ago

function seems to be changed, now uses the param --creator where I suppose we need to add the first Creator address of an NFT created by the CM2. So I think this issue should be just about updating the docs.

Yeah, I just hadn't updated the docs. Pushed an update just now. Thanks for the heads up.

AnderUstarroz commented 2 years ago

Why changed from candy machine ID to creator? isn't it confusing? people may try to use the NFT creator field (which can be spoofed) when is actually the Candy Machine ID what should be used.

samuelvanderwaal commented 2 years ago

Why changed from candy machine ID to creator? isn't it confusing? people may try to use the NFT creator field (which can be spoofed) when is actually the Candy Machine ID what should be used.

This is just a more accurate description of what was already happening. snapshot checks by first verified creator in the creators array to find NFTs. For NFTs minted with a candy machine that is the candy machine ID by default, but it doesn't have to be. Creators can be spoofed but verified creators can't so that's why it checks that the creator is verified.