samuelvanderwaal / metaboss

The Metaplex NFT-standard Swiss Army Knife tool.
Apache License 2.0
691 stars 220 forks source link

change update_authority for all #148

Closed MukulGari closed 2 years ago

MukulGari commented 2 years ago

In my candy machine v2 mint of 1000 nft i have given update authority to 2 account address and 1 is an hardware wallet and i wanna revoke it's authority from all of them. is their anything available for that in metaboss similarly to metaboss set update-authority-all --keypair --mint-accounts-file --new-update-authority for hardware wallets As solana cli allows to put wallet_url instead of keypair, does this work here too

samuelvanderwaal commented 2 years ago

I haven't had a chance to look into hardware wallet integration. Is it even possible to do a sign-all command with it without having to manually approve each transaction on the device?

MukulGari commented 2 years ago

Umm, yeah that's also my concern, if u can suggest how to add the integration part as solana cli allows to put wallet_url instead of keypair, and if we use the update-all sub-command and pass wallet url instead of . & then mostly we have to approve only once, can u plz check or suggest something here. or any other references u would suggest.

ref. https://docs.solana.com/wallet-guide/hardware-wallets#:~:text=Solana%20defines%20a%20keypair%20URL,wallet%20connected%20to%20your%20computer.&text=WALLET_ID%20is%20a%20globally%20unique,keys%20within%20your%20hardware%20wallet.

samuelvanderwaal commented 2 years ago

I spent a little time implementing Ledger support and it was really flaky on my machine and there's still the issue of having to approve manually for every tx. I might try again some other time.