Use assert/require.NoError() instead of Nil()

samuong / alpaca

A local HTTP proxy for command-line tools. Supports PAC scripts and NTLM authentication.

Apache License 2.0

184 stars 31 forks source link

Use assert/require.NoError() instead of Nil() #24

Closed samuong closed 4 years ago

samuong commented 4 years ago

I never really knew that there was a NoError() function until recently, so I was using Nil() instead. This pull request changes all the calls to Nil(t, err) to NoError(t, err)

samuong commented 4 years ago

Ah, good catch. I was just doing a blind search and replace for Nil(t, err) and had forgotten the cases where I wasn't checking an actual variable named err. This is fixed now. The remaining assert.Nil() calls are for non-error values, so I've left them.