search

samuong / alpaca

A local HTTP proxy for command-line tools. Supports PAC scripts and NTLM authentication.
Apache License 2.0
184 stars 31 forks source link

Read NoMAD configuration values from Managed Preferences #50

Closed segan5 closed 4 years ago

segan5 commented 4 years ago

Read NoMAD configuration values from /Library/Managed Preferences before reading them from ~/Library/Preferences.

I've done some testing and it all seems to work, UseKeychain is now being read from Managed Preferences plist while UserPrincipal is still being read from the user's preferences plist.

This will avoid users having to use that manual workaround on corporate managed devices that deploy a configuration profile to manage NoMAD.

Fixes: #32

samuong commented 4 years ago

Thanks Ern! Don't forget to add yourself to AUTHORS. You should probably also change "2019" to "2019, 2020" at the top of nomad_darwin.go as well.

segan5 commented 4 years ago

Thanks for the comments @camh-anz and @samuong! Bit of a novice at go so I welcome all the feedback.

segan5 commented 4 years ago

Thanks @camh- actually I don't think I can merge the PR, it is saying I don't have write access to the repo. Which is fine by me. So if someone with write access can merge it when convenient, that would be great.