search

samuraiexx / roll_together

It's an extension for Google Chrome that synchronizes Crunchyroll Videos that are being played at multiple computers
MIT License
52 stars 12 forks source link

Extension fails to work for new rooms on beta.crunchyroll.com #14

Closed JeromySt closed 3 years ago

JeromySt commented 3 years ago

Just wanting to report that the extension is not working as intended on beta.crunchyroll.com. This is likely a temporary issue until they go live with it but I wanted to let you know.

The beta can join an in-progress room, just there is no button to create a room.

samuraiexx commented 3 years ago

Thank you for your feedback!

I just merged a commit that's supposed to fix that issue. Can you update the extension to version 2.9.1 and let me know if it's working now?

JeromySt commented 3 years ago

Hello. I updated the extension and now it does not appear to load on either the normal site nor the beta site.

@samuraiexx , tagging you directly just in case. Can you confirm it's still working for you on the normal site as well?

hsnavarro commented 3 years ago

Could you please provide the full url (both normal and beta) of the episode where you are trying to use the extension.

JeromySt commented 3 years ago

https://beta.crunchyroll.com/watch/GN7UDZXWX/Divide and https://www.crunchyroll.com/rwby/episode-1-divide-798820

In both cases clicking on the RT icon only displays the Roll Together extension menu, no ability to create a Room. Previous to 2.9.1 the www.crunchyroll.com URI would properly show the Create a Room option.

hsnavarro commented 3 years ago

The extension is activated using a regex expression and both URLs that you sent passed when testing, so it shouldn't have any problem with showing the Create Room button properly. Both I and @samuraiexx have tried without success to reproduce this issue using Chrome for Windows x64. Are you using another browser? I would ask you to also try to reinstall the extension and reaccept the permission and see if works.

JeromySt commented 3 years ago

I'm using Microsoft Edge Chromium. I'll try re-installing the extension and report back.

JeromySt commented 3 years ago

Ok... re-install found the extension working on www.crunchyroll.com: image

beta.crunchyroll.com: image

note that extension installation only mentions www.crunchyroll.com (not sure if that matters): image

I think my previous issue with www.crunchyroll.com was with in-private/incognito session trying to test non-beta site before I figured out I could switch back and forth easily. So it would seem the regex isn't yet properly loading the extension on the beta site for some reason.

samuraiexx commented 3 years ago

@JeromySt thank you very much, that was a really complete description.

I'll start testing it on Edge as well and try to understand why you had to reinstall it but nice to know that people also use this extension on Edge.

If you are interested in the bug:

To make it easier to know when you can create a room, we do not show the "Create" option depending on your current URL and on the existence of an IFrame# with id #vilos-player.

My guess, now that allowing all Crunchyroll subdomains didn't work, is that on beta the IFrame Id is not vilos-player so instead of querying that, I changed it to query the IFrame source that's for sure still static.crunchyroll - thanks to your comment that ensured that it was still working, even though you were not able to create a room.

I'll wait for @hsnavarro to take a look at my PR and if everything is fine I'll deploy and let you know here when the new version is released.

Again, thank you =]

JeromySt commented 3 years ago

I have exported the source for an example beta site video so you folks can look through it and tailor your fix. source.zip

JeromySt commented 3 years ago

Just commenting that I have validated 2.9.2 fixes the extension for beta.crunchyroll.com. Thank you for spending the time to fix this!

hsnavarro commented 3 years ago

Thanks for the help providing the information needed to find a solution for your problem.