Closed clurdish closed 2 years ago
@samuraiexx @hsnavarro Let me know if you have any feedback on this. Happy to discuss any of the changes.
Looks great! Thank you very much for those changes. I'll also change the server to update the socket.io version and improve the path a little bit (since I need to support old versions I can't just change the server version because of compatibility between socket.io versions). By the way, is there a specific feature of the new version that you think it's worth using? I will wait for @hsnavarro to review before merging but looks amazing!
I have submitted a PR to the server branch for updating Socket.IO and adding TypeScript support to bring the server in line with the client. See: https://github.com/samuraiexx/roll_together_backend/pull/5
The good news with the server side is that it is backwards compatible with older client versions. So deploying the server update first wouldn't disrupt existing clients, no need to worry about deploying at the exact same time.
In terms of updating to the newer version, I don't see any specific features yet. But I think there are a couple reasons to update
@hsnavarro Any feedback on this from your end?
@hsnavarro Any feedback on this from your end?
Hey, I already told @samuraiexx to approve it, but he probably forgot. I'll remind him again.
There are a few things this PR accomplishes, mostly to make contributions easier and safer.
window
type for background for better type checking across windowsenv.json
file to automatically include environment variables