samuraiexx / roll_together

It's an extension for Google Chrome that synchronizes Crunchyroll Videos that are being played at multiple computers
MIT License
52 stars 12 forks source link

[Feature Request] View Users in the Current Room #22

Open clurdish opened 2 years ago

clurdish commented 2 years ago

Summary

As a user of the browser extension, I would like to be able to see who is in the room at a given time, so that it's clear if my friends have joined yet or disconnected.

Details

This would probably consist of a few additions between the extension and the back-end server.

Some potential "nice-to-haves"

samuraiexx commented 2 years ago

Hmm. That is a feature that I was going to add, the only problem is the design itself - the backend server already sends this information, it's just not displayed on the frontend.

If you have design suggestions, please let me know. I agree that's an important feature in general.

clurdish commented 2 years ago

I'm thinking something like this for the connected users. Nothing too special, but would get the job done. Obviously the styling is mostly just a placeholder, we could do whatever we want there.

image

In terms of the back-end, we're currently keeping track of the socket ID for each user, but we would also need to keep track of and broadcast updates to profile name. Basically, we'd have the clients be in charge of telling the server what to call them. I figure we could write it in such a way that we could track any arbitrary metadata about a user such as an avatar (if we decide to implement that).

The user display name could be a randomly generated value by default, and then add a section to the extension options page for users to customize it.

I'd be glad to take a stab at it, unless this is something you'd prefer to take on personally.

samuraiexx commented 2 years ago

Hmm, I think that we can just pass this information when someone joins and ignore updates in the same room, to make it easier.

About the design, it looks really good, I would probably change it to be a list of avatars, just the circles, and display the names on hover. I agree with having a predefined name as well and letting the user reshuffle. Probably we should use a wordlist so we don't need to trust the client (the client can pass an id for the nickname as well)

The image could be predefined so we just need to pass an id.