search

samuraiexx / roll_together

It's an extension for Google Chrome that synchronizes Crunchyroll Videos that are being played at multiple computers
MIT License
52 stars 12 forks source link

Skip intro button #7

Closed hsnavarro closed 4 years ago

hsnavarro commented 4 years ago

Implementation of a skip intro button, the button only appears if the skip intro feature is activated and the back-end has informed the intro begin and end time. If the user presses the button, the reproduction time will jump to the intro end time.

The button has 3 exhibition modes: Constant - button is always visible Hover - button is only visible when the mouse is over it Hidden - button isn't displayed

Exhibition times: Constant - first 5 seconds of the intro Hover - after the first 5 seconds, until the intro ends Hidden - all other cases

In options, there is a toggle button to activate / deactivate the skip intro feature, if the user changes this option, the page responsible for the video reproduction needs to be reloaded to consider the new setting.

Main Changes: Created skip intro button (on the video reproduction page) Created toggle button to activate / deactivate skip intro feature (on the extension options page)

Skip intro button layout: image

New options page layout: image

samuraiexx commented 4 years ago

That was a great PR description! Also, I liked the way you coded the states and states transitions of the skip button.