search

samurailink3 / hangouts-against-humanity

A game for horrible people, on Google+, in a hangout.
GNU Affero General Public License v3.0
110 stars 35 forks source link

NEIndy #18

Closed ericpinhat closed 11 years ago

ericpinhat commented 11 years ago

i added like 45 or so cards to a deck and its listing as a proposed change. do i have to wait for it to be approved?

thanks. eric.

samurailink3 commented 11 years ago

It looks good to me. Let me talk to @joshuha about how we are going to handle expansions. I have a feeling a better idea may be for us to have separate files pulled in for the expansion packs, that way, we don't eventually end up with a 50MB cards.js file.

ericpinhat commented 11 years ago

Awesome. Thanks for keeping me updated.

Eric.

Sent from my iPhone

On Jan 24, 2013, at 4:32 AM, Tom Webster notifications@github.com wrote:

It looks good to me. Let me talk to @joshuha about how we are going to handle expansions. I have a feeling a better idea may be for us to have separate files pulled in for the expansion packs, that way, we don't eventually end up with a 50MB cards.js file.

— Reply to this email directly or view it on GitHub.

BradLeclerc commented 11 years ago

Any update on planned method for expansions? I'm hoping to start adding in a bunch of stuff (or at least propose a pile of new cards), but don't really want to to be building up pull requests if there's gonna be a more standard method soon...

joshuha commented 11 years ago

I am researching changing some pretty big backend stuff on the way the hangout data is synced so haven't had much of a chance to think on this yet. If you are planning on wanting to use them in the next couple of weeks I would say go ahead and try and merge them in the cards.json file for now (and appropiate UI in CAH.game.js).

samurailink3 commented 11 years ago

@BradLeclerc - Go ahead and re-run the pull request on the samurailink3:develop branch, I'll add a selector to the main game and then merge it into the master branch.

@joshuha - We may want to look at making an announcement in the community about changing the game launch link to the Github page, this way, people are always launching an up-to-date copy of the game. And it makes updates so much easier.

samurailink3 commented 11 years ago

I've manually merged the changes in (due to the develop branch being out of date, I've deleted in since then). This expansion will show up in the game as soon as I push it to RackSpace (it will be today).

Reference commitish: 004ad1ea3f6dadeae57cc80520203c268b2b5918

samurailink3 commented 11 years ago

@BradLeclerc - If you'd like to add an expansion, go ahead and make a pull request off of master, I'll merge it in.

BradLeclerc commented 11 years ago

I'll figure out how to set that up later today or tomorrow hopefully. :D

On Tue, Mar 12, 2013 at 1:27 PM, Tom Webster notifications@github.comwrote:

@BradLeclerc https://github.com/BradLeclerc - If you'd like to add an expansion, go ahead and make a pull request off of master, I'll merge it in.

— Reply to this email directly or view it on GitHubhttps://github.com/samurailink3/hangouts-against-humanity/pull/18#issuecomment-14789831 .