search

samurailink3 / hangouts-against-humanity

A game for horrible people, on Google+, in a hangout.
GNU Affero General Public License v3.0
110 stars 35 forks source link

Card Loading #22

Open kspier opened 11 years ago

kspier commented 11 years ago

We appear to have broken the game. No cards would load, regardless of what sets we selected.

kspier commented 11 years ago

Alright. Looking at this, I notice two things. I don't know if this will affect the coding at all. But:

(1) In the cards,js, there appears to be one text bit missing a ____ and having used too many underscrores (what I get for letting someone else write text).

(2) There looks like there's a carriage return in the other file. My coding instincts say that seems odd to me, however, as that carriage return was in there before my addition.

samurailink3 commented 11 years ago

Looks like the loading error was caused by an extra bracket.

What line needs to be fixed? I'll push another fix real quick.

kspier commented 11 years ago

Not sure - it's the question cards that I noticed, but I honestly don't know if that'll cause an issue. If it does, I can submit a quick pull request. We're about to test it.

samurailink3 commented 11 years ago

I don't think the extra underscore would cause an issue, its really more of a display label, I don't think any code is written against those characters specifically. If you notice any issues in testing, let me know.

kspier commented 11 years ago

Right now we're in an odd setup. We have a game up and running now. Three of us in there. The game only worked when started by one of us who did not have the Not Safe For Humanity set appearing in their checklist (in fact, it did not appear for two of us). The one who did have the option could start the game, and we would not get cards again.

joshuha commented 11 years ago

Did everyone clear cache and restart browser?

joshuha commented 11 years ago

And I do replace underscores so having multiple will make it reeeeally long.

cardText = cardText.replace(/_/g,'__');

kspier commented 11 years ago

Ah, that makes sense. I can go edit the underscores and do another pull request later.

We've had a number of people clearing the cache.

samurailink3 commented 11 years ago

Ah, ok. Thanks for the clarification @joshuha