search

samurailink3 / hangouts-against-humanity

A game for horrible people, on Google+, in a hangout.
GNU Affero General Public License v3.0
110 stars 35 forks source link

Add CAH Fourth Expansion #44

Closed enricob closed 10 years ago

enricob commented 10 years ago

I received my Fourth Expansion set a couple of days ago, so I thought I'd try and update HAH with the new cards. I noticed that there are no cards with numAnswers of 3, so I omitted one black card from Fourth Expansion which is a "Draw 2, Pick 3". Please advise on that point.

Also, I haven't actually tested any of this at all. I was careful about following existing formatting/conventions but that's really the only assurance I can give that this works. What's the easiest way to test the game locally?

samurailink3 commented 10 years ago

There are cards with numAnswers:3, those are handled properly. Go ahead and add the black card back in.

Unfortunately, there isn't a good way to test locally unless you wanted to stand up your own version of the HAH app on the Google App Engine Hangouts API. We use a test domain with an SSL cert to run our test games (which we have to either modify the code to do, or have 3 people handy)

enricob commented 10 years ago

Yes, that was my mistake: I was typing my search incorrectly so I didn't find any of the numAnswers:3 cards. I've added in the missing card. I was trying to test the app with my own domain but I can't get SSL going, so none of the game assets will load in the test hangout. =(

samurailink3 commented 10 years ago

I've gotten it to work on Dropbox Public Folders in the past, but I haven't tried that in a year or so. May be worth a shot.

enricob commented 10 years ago

I tried Dropbox Public Folder and that seems to work. I had to fix some JS errors in the cards file. I figured I had to have made some mistake. Good thing I tested. =P