samurailink3 / hangouts-against-humanity

A game for horrible people, on Google+, in a hangout.
GNU Affero General Public License v3.0
110 stars 35 forks source link

Add the extra options section, which includes 'Narcissism Mode' #47

Closed enricob closed 10 years ago

enricob commented 10 years ago

I was inspired by one of the gifts from this year's 12 Days of Holiday Bullshit.

When I received a card with my own name printed on it, I thought it would be cool to give players the option to insert white cards bearing their own names into the game.

One caveat is that the extra cards are added when the game starts, so the set of players that are in the game at the time it starts get white cards. Players who enter later don't get white cards added for them and players who leave don't cause white cards to be removed. I think this is how it should work, though.

I haven't had a chance to test this fully but I thought I'd send the pull request to get your thoughts. At this point, I can verify that the app launches without Javascript errors, that the extra options checkbox group appears when starting a game, and that the initDecks function recognizes when the "Narcissism Mode" option is turned on and off. When "Narcissism Mode" is turned on, I can see the card with my name on it in the log. To be fully confident this change works, I need to try it in an actual game with more people.

Happy holidays~! EB

enricob commented 10 years ago

I've had a chance to test this change out in games with friends. I can confirm that the Narcissism Mode cards get mixed in with the white cards and they did get played a couple of times during out testing session. They even got pretty nice reception.

Feeling a bit more confident now that this change doesn't completely break the game but take a look and let me know if you spot anything that's amiss or if you think it needs more thorough testing.

samurailink3 commented 10 years ago

Looks good! I'll get this merged in soon. Sorry for the delay, holidays and recent work have kept me very busy.