search

samuraisam / django-json-rpc

JSON-RPC Implementation for Django
MIT License
286 stars 83 forks source link

Updating package verison and required Django version #85

Open calyth opened 8 years ago

calyth commented 8 years ago

6d864e1 fixed a Django 1.9 incompatibility. Bumping the package version, and required django version

samuraisam commented 8 years ago

Hmm. I don't think this is actually what we want, because the django-json-rpc package is actually compatible with older versions of Django.

calyth commented 8 years ago

Hmm. So I played around a bit, and the json browser didn't complain about the missing -{% load url from future %} when I used Django 1.8.13.

Would it be sufficient to drop the django version restriction (i.e. revert back to Django>=1.0), and publish a new version of this package without the load url from future in the template?

On Tue, Jul 12, 2016 at 9:12 PM Samuel Sutch notifications@github.com wrote:

Hmm. I don't think this is actually what we want, because the django-json-rpc package is actually compatible with older versions of Django.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/samuraisam/django-json-rpc/pull/85#issuecomment-232227899, or mute the thread https://github.com/notifications/unsubscribe/AC2egmEwiccbsCeryhCjAV7k0utk-4pPks5qVDt4gaJpZM4JK-Ui .

samuraisam commented 8 years ago

Probably, and to be honest, I don't think many people are using the JSON-RPC "explorer" which was a feature I added for a client a long time ago, and have considered removing ever since. I'd be happy with removing that entire thing, and if people wanted it, could either pin to an older version of django-json-rpc, or could pull it into their project.

calyth commented 8 years ago

I find the browser could be useful as a means of discovering what's there. It's not super critical, but might be nice if people could pick up the change from PyPI.