search

samuraitruong / coingecko-api-v3

The nodejs api library for accessing coingecko api v3 , develop with typescript
https://samuraitruong.github.io/coingecko-api-v3/
MIT License
54 stars 30 forks source link

fix: https polyfill for react-scripts > 5 #14

Closed kkx64 closed 2 years ago

kkx64 commented 2 years ago

fix: react-scripts > 5 uses newer webpack, which errors out about polyfills

samuraitruong commented 2 years ago

@kkx64 kkx Thanks for PR can you help to fix the test?

kkx64 commented 2 years ago

@kkx64 kkx Thanks for PR can you help to fix the test?

@samuraitruong I'll take a look and make a new PR if I manage to fix it :)

kkx64 commented 2 years ago

@kkx64 kkx Thanks for PR can you help to fix the test?

Tests fixed

codecov-commenter commented 2 years ago

Codecov Report

Merging #14 (26a04e6) into main (47e472d) will decrease coverage by 0.83%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
- Coverage   94.40%   93.57%   -0.84%     
==========================================
  Files           2        2              
  Lines         161      140      -21     
  Branches        5        3       -2     
==========================================
- Hits          152      131      -21     
  Misses          9        9
Flag Coverage Δ
unittests 93.57% <100.00%> (-0.84%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/CoinGeckoClient.ts 91.50% <ø> (-1.00%) :arrow_down:
src/Enum.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 47e472d...26a04e6. Read the comment docs.