search

samuraitruong / coingecko-api-v3

The nodejs api library for accessing coingecko api v3 , develop with typescript
https://samuraitruong.github.io/coingecko-api-v3/
MIT License
54 stars 30 forks source link

PLATFORMS enum is not correct #15

Closed morph-dev closed 1 year ago

morph-dev commented 2 years ago

The PLATFORMS enum is defined like this:

export type PLATFORMS = 'ethereum' | 'tron'

There are so many other platforms available.

In my opinion, this should be one of:

  1. All returned by: /asset_platforms
  2. All that appear in: /coins/list?include_platform=true
  3. Doesn't exist at all, and if needed as type, string should be used as well (with additional documentation)
    • Since first 2 option require manual update every once in a while, this might be the most flexible approach
samuraitruong commented 2 years ago

@morph-dev PLATFORMS type was defined when I made this lib so at that time it only have ethereum and tron. Maybe coingecko update their support now, I will check and extends that constants

digimbyte commented 1 year ago

resolved?

souvik666 commented 1 year ago

@samuraitruong hey i have updated the platform enums https://github.com/samuraitruong/coingecko-api-v3/pull/41