search

samuri51 / chillybot

a turntable bot created by a moderator of straight_chillin11
12 stars 12 forks source link

/djplays crashing bot #1

Closed btburbank closed 11 years ago

btburbank commented 11 years ago

bot error When the q is on, issuing the command /djplays causes the bot to throw an error, and crash. The command only works once.

samuri51 commented 11 years ago

thanks for bringing this to my attention, i don't usually use that feature so i didn't notice it, i'll start working on a bug fix asap.

samuri51 commented 11 years ago

can you please tell me what settings you were using? are you able to reproduce this error? i just tested it and it worked fine for me, obviously i know i must not be reproducing the circumstances properly.

btburbank commented 11 years ago

The bot only enforces the q one time. After it removes the 1st dj, it no longer removes users. Issuing the /djplays command causes it to crash. I have the bot's queue set to one play. Is that too soon? Yes. The error is reproducible.

samuri51 commented 11 years ago

ok i think i know what's happening

btburbank commented 11 years ago

How can I fix it?

samuri51 commented 11 years ago

i just uploaded the fix to github, try the new script and see if you still get the same error.

samuri51 commented 11 years ago

also the thing you have to know about the song limit is that i specifically made it not work on moderators or the bot, i can change that if you want

btburbank commented 11 years ago

That is the issue i think. Most of my DJ'S are moderators. Can you change that?

samuri51 commented 11 years ago

do you want the bot to be kicked off after the limit too?

btburbank commented 11 years ago

No. I'd like for the bot to treat moderators as any other dj. If that makes any sense.

samuri51 commented 11 years ago

ok try the updated script now and let me know if its still giving you problems, i made it so moderators get kicked off too, however the bot still does not get kicked off after a limit, i can change that too, but the logic behind that one is that if you don't want the bot to play a song then you can turn its autodjing off

btburbank commented 11 years ago

It makes sense to me. I will update the bot and let you know if i have any issues.

btburbank commented 11 years ago

Ok, the bot is no longer crashing, and it properly removes moderator dj's. One question. Would it be possible to have it keep track of dj plays without the q being on?

samuri51 commented 11 years ago

yes but is there a problem with the queue as it is? you dont have to add yourself to it unless someone else already added themselves to it

samuri51 commented 11 years ago

btw just in case you didn't know you don't have to fork this github in order to use it, all you have to do is hit the zip button to download the files, then copy and paste your setup overtop the setup in the new script

samuri51 commented 11 years ago

and the logic behind only tracking the song plays when the song play limit is in play is that you don't need to know how many songs a dj has played unless theyre going to be kicked for it, and typically the point of having a queue is to enforce a song limit

btburbank commented 11 years ago

Well, I forked this because I've made some changes of my own to the bot. I plan to upload my version of it once I figure out how github works.

btburbank commented 11 years ago

The reason why I asked about the song plays is, it's nice to know how many songs you or someone has played in the room.

btburbank commented 11 years ago

But the q is fine now.

samuri51 commented 11 years ago

ooo what kinda changes? :D

btburbank commented 11 years ago

Come check him out in my room.

http://turntable.fm/all_music_mix_online

I added scott pilgrim quotes, and made some other small response changes. Rewording

samuri51 commented 11 years ago

sweet, i'll cheggit out ina bit

btburbank commented 11 years ago

Ok, can you mark this issue as closed Then? Look forward to you stopping by.