Implements Google Picker support for the Google Provider

samvera-deprecated / browse-everything-redux-react

React user interface for browse-everything

Other

0 stars 3 forks source link

Implements Google Picker support for the Google Provider #45

Closed jrgriffiniii closed 4 years ago

jrgriffiniii commented 4 years ago

This also addresses several additional issues:

Begins i18n support
Improves support for JWT authorization

jrgriffiniii commented 4 years ago

This needs some commits rebased, but this should be enough to provide a proof-of-concept.

jrgriffiniii commented 4 years ago

Currently there is a bug in which the Google Picker API might not be returning JSON results consistently. For example, I find the following when mounting the user interface in Rails:

Where I should be using the id_token property (at least in some cases), I was only originally looking for access_token on the auth. response JSON Object.

jrgriffiniii commented 4 years ago

https://github.com/samvera-labs/browse-everything-redux-react/pull/45/commits/6eeadd79cdd1153ca6f13f3eed1184fe221952d0 rebases and fixes this more thoroughly, although I am not certain why this is happening. With invalid App. Key and Client IDs passed for the Google API, clear and verbose errors are logged in the console.

jrgriffiniii commented 4 years ago

Merging this in order to advance the 2.0.0.pre.alpha1 release.