search

samvera-deprecated / curation_concerns

A Hydra-based Rails Engine that extends an application, adding the ability to Create, Read, Update and Destroy (CRUD) objects (based on Hydra::Works) and providing a generator for defining object types with custom workflows, views, access controls, etc.
Other
15 stars 27 forks source link

Replace CurationConcerns::NullLogger with ActiveFedora::NullLogger #1007

Open awead opened 7 years ago

awead commented 7 years ago

There's a PR in on ActiveFedora to use NullLogger, https://github.com/projecthydra/active_fedora/pull/1153, which is the same as Curation Concerns' null logging object. Once that PR is merged, we can just use that one instead.

botimer commented 7 years ago

The AF PR is merged, but there is no release containing it yet. Also, it is not clear when it is safe to bump the gemspec dependency to 11.0.x. It's currently '>= 10.3.0.rc1'.

I'm happy to tidy this up with some advice on the versioning.

awead commented 7 years ago

I think all we need to do is cut a new release of AF.

jcoyne commented 7 years ago

If we require AF 11, you'll transitively require rdf 2, which may be a problem for some users

awead commented 7 years ago

I can backport the NullLogger to version 10, if needed.

botimer commented 7 years ago

Got it. Since the point is that the logger does nothing, I'd be inclined to leave it in place and close this. Not too much value in binding across gems here when there's no real risk of desync or duplication. And there's a downside in dangling issues.

awead commented 7 years ago

meh. I'm inclined to backport because it'd be nice to not have the duplication, alternatively, we could tag this for a version of CC that requires AF 11.

botimer commented 7 years ago

Right. I'm not really invested in any of these approaches -- it's just not the obvious housekeeping thing it seemed to be. A release of AF is needed to address it or a decision made that it's okay as-is.

I'm happy to port/PR to AF 10.3-stable and bump the CC gemspec if that's the winner. Up to you two.