search

samvera-deprecated / curation_concerns

A Hydra-based Rails Engine that extends an application, adding the ability to Create, Read, Update and Destroy (CRUD) objects (based on Hydra::Works) and providing a generator for defining object types with custom workflows, views, access controls, etc.
Other
15 stars 27 forks source link

Workflow i18n translations missing if work type is not called 'Generic Work' #1043

Closed randalldfloyd closed 8 years ago

randalldfloyd commented 8 years ago

The new workflow i18n translations are keyed to curation_concerns.workflow.generic_work, but if you use the CC work type generator and call your new type something arbitrary, it will produce translation missing errors. Either the translations should not use the work type name, or the generator will need to take care of adding the translations when new work types are created.

jeremyf commented 8 years ago

One solution is that our translations should have a "suitable" default. In this case, I would assume translating Sipity::Action#name should fall back to Sipity::Action#name.titlelize.

jeremyf commented 8 years ago

Closing with @bb3013c701afc518be071d09db529ca7b9ad8e79.

If this does not resolve the problem, please re-open with further details (i.e. call stack)