search

samvera-deprecated / curation_concerns

A Hydra-based Rails Engine that extends an application, adding the ability to Create, Read, Update and Destroy (CRUD) objects (based on Hydra::Works) and providing a generator for defining object types with custom workflows, views, access controls, etc.
Other
15 stars 27 forks source link

Consider removing notifiable contexts from Sipity::WorkflowState #1054

Closed jcoyne closed 7 years ago

jcoyne commented 8 years ago

I think the notifiable_contexts in Sipity::WorkflowAction ought to be sufficient.

jcoyne commented 8 years ago

@jeremyf what do you think of this proposal?

jeremyf commented 8 years ago

The plan would be to replace those with functions as part of the callback? I can get behind that. It would move the configuration of emails out of the database and into a function.

jcoyne commented 8 years ago

@jeremyf I don't think I made myself clear. Presently it allows WorkflowState and WorkflowAction to be notifiable contexts. I'm positing that we don't need notifiable contexts for both states and actions. I think that notifications should happen only on WorkflowActions.

jcoyne commented 7 years ago

@jeremyf ping?

mjgiarlo commented 7 years ago

:arrow_up: @jeremyf comments?

jeremyf commented 7 years ago

Yes. Notifications need only happen for actions.

Jeremy Friesen

On Jan 10, 2017 12:30 PM, "Michael J. Giarlo" notifications@github.com wrote:

⬆️ @jeremyf https://github.com/jeremyf comments?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/projecthydra/curation_concerns/issues/1054#issuecomment-271640954, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAIUi3VIh_KVVmqfvev6_5KysB0Rm7Yks5rQ8AzgaJpZM4KVGMF .

mjgiarlo commented 7 years ago

OK, I'll move this to Hyrax. Thanks!

mjgiarlo commented 7 years ago

Moved to Hyrax: https://github.com/projecthydra-labs/hyrax/issues/231 Closing.