search

samvera-deprecated / curation_concerns

A Hydra-based Rails Engine that extends an application, adding the ability to Create, Read, Update and Destroy (CRUD) objects (based on Hydra::Works) and providing a generator for defining object types with custom workflows, views, access controls, etc.
Other
15 stars 27 forks source link

Render the unavailable template if user cannot act on a work in current workflow state #1080

Closed luisgreg99 closed 7 years ago

luisgreg99 commented 7 years ago

Fixes projecthydra/sufia#2727

mjgiarlo commented 7 years ago

@jcoyne I addressed your requested changes and rejiggered the impl a bit. I'm running into two failures that I don't understand; if you get a couple minutes, would you mind taking a look at the Travis failures?

mjgiarlo commented 7 years ago

@jcoyne I believe the changes I've made address your review.

Note though that this pulls in the feature/SuppressObjectForWorkflow branch which adds the ability to ask Solr docs if they are suppressed. I've pushed this branch up to show that the approach works, but before it can be merged, I will need to disentangle the two branches once https://github.com/projecthydra/curation_concerns/pull/1103 is merged, and then rebase on master

In the meantime, @jcoyne, are you inclined to re-review this PR?

mjgiarlo commented 7 years ago

@jcoyne :green_heart: This is ready for another review.

mjgiarlo commented 7 years ago

@jcoyne I made some/many of the changes you requested, but this work was rushed and tbh I'm not sure I'm on the right track. So if things are broken or seem half-done, it's only because they are. Could use some pointers tomorrow. Thx for the review.

mjgiarlo commented 7 years ago

@jcoyne re-review? :)