search

samvera-deprecated / curation_concerns

A Hydra-based Rails Engine that extends an application, adding the ability to Create, Read, Update and Destroy (CRUD) objects (based on Hydra::Works) and providing a generator for defining object types with custom workflows, views, access controls, etc.
Other
15 stars 27 forks source link

Removing an exclusion for a non-existent file #1168

Closed jeremyf closed 7 years ago

jeremyf commented 7 years ago

Using the following script, found several files that were not referenced.

require 'psych'
yaml = Psych.load_file('./.rubocop.yml')

def read(node)
  if node.is_a?(Hash)
    node.each_pair do |key, value|
      read(value)
    end
  elsif node.is_a?(Array)
    node.each do |value|
      read(value)
    end
  elsif node.is_a?(String)
    return unless node =~ /.rb\Z/
    return if node =~ /\*/
    return if File.exist?(node)
    puts node
  end
end
read(yaml)

Fixes #issuenumber ; refs #issuenumber

Present tense short summary (50 characters or less)

More detailed description, if necessary. Try to be as descriptive as you can: even if you think that the PR content is obvious, it may not be obvious to others. Include tracebacks if helpful, and be sure to call out any bits of the PR that may be work-in-progress.

Description can have multiple paragraphs and you can use code examples inside:

class PostsController
  def index
    respond_with Post.limit(10)
  end
end

Changes proposed in this pull request:

@projecthydra/sufia-code-reviewers