search

samvera-deprecated / curation_concerns

A Hydra-based Rails Engine that extends an application, adding the ability to Create, Read, Update and Destroy (CRUD) objects (based on Hydra::Works) and providing a generator for defining object types with custom workflows, views, access controls, etc.
Other
15 stars 27 forks source link

Add a test for collections migration task #1175

Closed hackartisan closed 7 years ago

hackartisan commented 7 years ago

Here's how far I got; test fails as follows:

    NoMethodError:
       undefined method `all' for CurationConcerns::Collection:Module
     # ./lib/curation_concerns/data_migration/collections_migration.rb:6:in `run'
     # ./spec/lib/curation_concerns/data_migration/collections_migration_spec.rb:22:in `block (3 levels) in <top (required)>'

Could use some guidance @tpendragon @escowles

escowles commented 7 years ago

Maybe a namespacing issue? Does ::Collection.all.each work?

hackartisan commented 7 years ago

@escowles thanks; that cleared the error!

hackartisan commented 7 years ago

No idea what is up with this https://travis-ci.org/projecthydra/curation_concerns/jobs/216900075#L1769

escowles commented 7 years ago

I don't know what that error is either, but @tpendragon mentioned it yesterday.

hackartisan commented 7 years ago

@tpendragon Can you at least accept this PR into your branch? the failing test exists in both.