search

samvera-deprecated / curation_concerns

A Hydra-based Rails Engine that extends an application, adding the ability to Create, Read, Update and Destroy (CRUD) objects (based on Hydra::Works) and providing a generator for defining object types with custom workflows, views, access controls, etc.
Other
15 stars 27 forks source link

Is projecthydra/sufia-code-reviewers group working? #833

Closed escowles closed 8 years ago

escowles commented 8 years ago

Descriptive summary

A new PR was just opened by @eliotjordan: #832

The PR included the @projecthydra/sufia-code-reviewers group but it doesn't look like the group was notified (I didn't get an email AFAICT).

Expected behavior

Sufia code reviewers should be notified.

Actual behavior

Not sure if they were or not.

escowles commented 8 years ago

Related, as a member of the group, I can see the membership list at https://github.com/orgs/projecthydra/teams/sufia-code-reviewers

But it looks like non-members cannot view the membership (and get a 404). Should the membership list be public? Can it?

mjgiarlo commented 8 years ago

It's a visible group now. I wonder if it's fixed?

jpstroop commented 8 years ago

I can see it.

jpstroop commented 8 years ago

and I can ping @projecthydra/sufia-code-reviewers. Closing.