search

samvera-deprecated / curation_concerns

A Hydra-based Rails Engine that extends an application, adding the ability to Create, Read, Update and Destroy (CRUD) objects (based on Hydra::Works) and providing a generator for defining object types with custom workflows, views, access controls, etc.
Other
15 stars 27 forks source link

tons of ReferenceErrors when running jasmine via rake #934

Closed hackartisan closed 8 years ago

hackartisan commented 8 years ago

see https://gist.github.com/hackmastera/55a97346bd465bd0f9bd534874b20771

to replicate:

This must be a configuration issue somehow because rspec runs them fine.

jcoyne commented 8 years ago

@hackmastera can you do a git bisect and determine which commit broke it?

hackartisan commented 8 years ago

yes, good idea.

hackartisan commented 8 years ago

i tried to run tests on v1.3.2. I get the following:

rake aborted!
NoMethodError: undefined method `helper' for ActionController::API:Class
/home/ubuntu/src/curation_concerns/.internal_test_app/config/environment.rb:5:in `<top (required)>'
/home/ubuntu/src/curation_concerns/tasks/jasmine.rake:9:in `block (2 levels) in <top (required)>'
/usr/local/bin/bundle:23:in `load'
/usr/local/bin/bundle:23:in `<main>'
Tasks: TOP => curation_concerns:jasmine
(See full trace by running task with --trace)
hackartisan commented 8 years ago

just a note here, as i look for something i can both build and mark 'bad' for git bisect... ccf75db is showing the same failures originally reported.

hackartisan commented 8 years ago

Looks like this is caused by the same es6 preprocessor issues as https://github.com/projecthydra/curation_concerns/issues/896 was. everything is fine on ccf75db When I use hydra-editor 2.0.

hackartisan commented 8 years ago

Okay. With cc at ccf75db, https://github.com/projecthydra/hydra-editor/commit/d38f1e7 introduces one error into cc, pasted below. The hydra-editor commit before this one gives passing tests.

At the next cc commit, e6e9f74, the one where @tpendragon refactored the file manager to work with almond, pinning to either of these hydra-editor commits gives the originally-reported errors. It seems like the refactor just isn't registering in jasmine with or without almond coming through from hydra-editor.

That's all the forensics I have in me. Let me know if this jogs anything for you, @jcoyne or @tpendragon. Tests run on jasmine server in sufia so maybe there is a trick to the difference in setup there.

23 specs, 1 failure
Spec List | Failures
FileManager Save Button #persist is called by clicking the save button
Error: No hydra-editor/field_manager
Error: No hydra-editor/field_manager
    at callDep (http://dev.hydra.chemheritage.org:8888/assets/almond.self-3921caa456bd6df6e95fef599cb2bf043bab471b22c8608fc49a7d8f5ca1e46d.js?body=1?body=true:181:19)
    at req (http://dev.hydra.chemheritage.org:8888/assets/almond.self-3921caa456bd6df6e95fef599cb2bf043bab471b22c8608fc49a7d8f5ca1e46d.js?body=1?body=true:342:20)
    at jQuery.$.fn.manage_fields (http://dev.hydra.chemheritage.org:8888/assets/hydra-editor/manage_repeating_fields.self-d6fee0b6a2aefa58f7c2ac3bc3666607df5b4e48a570b0dda3846513414ad538.js?body=1?body=true:27:28)
    at http://dev.hydra.chemheritage.org:8888/assets/hydra-editor/editMetadata.self-c7ac87992156af24f33485bdcead5fbfffe47e54b763c000ba3b4a686ce59e1c.js?body=1?body=true:2:32
    at Object.activate (http://dev.hydra.chemheritage.org:8888/assets/blacklight/core.self-e031fb8c0ca3c81276d0c01490bcff1366bcec5ed64f6901b6a5c229dfd0829f.js?body=1?body=true:10:19)
    at Object.<anonymous> (http://dev.hydra.chemheritage.org:8888/__spec__/save_manager_spec.coffee:56:20)
    at attemptSync (http://dev.hydra.chemheritage.org:8888/__jasmine__/jasmine.js:1886:24)
    at QueueRunner.run (http://dev.hydra.chemheritage.org:8888/__jasmine__/jasmine.js:1874:9)
    at QueueRunner.execute (http://dev.hydra.chemheritage.org:8888/__jasmine__/jasmine.js:1859:10)
    at Spec.queueRunnerFactory (http://dev.hydra.chemheritage.org:8888/__jasmine__/jasmine.js:697:35)
hackartisan commented 8 years ago

fixed via #941