search

samvera-deprecated / geo_concerns

PCDM based geospatial models for Hydra
Apache License 2.0
3 stars 4 forks source link

Remove image derivative method? #265

Closed eliotjordan closed 7 years ago

eliotjordan commented 7 years ago

Do we need the image_derivatives method in GeoConcerns::FileSet::Derivatives? Seems redundant and could cause conflicts with overrides in host applications.

https://github.com/projecthydra-labs/geo_concerns/blob/master/app/models/concerns/geo_concerns/file_set/derivatives.rb#L21-L28

eliotjordan commented 7 years ago

@drh-stanford Can you think of any reason why we would need to process scanned map / image derivatives in a special way?

drh-stanford commented 7 years ago

is that code overriding regular hydra-derivatives? i don't think we need that if so...

eliotjordan commented 7 years ago

@drh-stanford Yeah, we're just overriding hydra-derivatives. PR to fix this: https://github.com/projecthydra-labs/geo_concerns/pull/266