search

samvera-deprecated / geo_concerns

PCDM based geospatial models for Hydra
Apache License 2.0
3 stars 4 forks source link

Leave config within the gem. #300

Closed afred closed 7 years ago

afred commented 7 years ago

Before this PR, much of the config that GeoConcerns relies on was copied into the host application via Rails generators. This PR moves those configs from generator templates into the gem's code base, where the Rails host app will still be able to find and load them, but they will be less likely to conflict with other gems, or with future upstream changes to Hyrax.

This is in compliance with the possible Hydra Plugin Guideline currently being discussed here:

https://github.com/projecthydra-labs/hydra_plugins_wg/issues/29

Closes #297.

afred commented 7 years ago

Note: when I start FCR and Solr locally with bundle exec rake geo_concerns:test_servers and then run bundle exec rspec spec, all tests pass. But when running bundle exec rake ci locally, I get the same error Travis is throwing.

eliotjordan commented 7 years ago

@afred That is strange. I'll poke around a little and see what I can find.

eliotjordan commented 7 years ago

Not sure why this doesn't work when running rake ci but does work when runing rspec spec, but Questioning Authority assumes that relative paths are relative to Rails.root.

https://github.com/projecthydra-labs/questioning_authority/blob/cf576add23e6346b1ca533dc6d3514f2ec2aebb3/lib/qa/authorities/local.rb#L19-L25