search

samvera-deprecated / hydra

Project Hydra Stack Dependencies
Other
83 stars 30 forks source link

Downgrade rsolr version #1

Closed mark-dce closed 11 years ago

mark-dce commented 11 years ago

rsolr version 2.0.0 doesn't appear to exist in public repos.  rsolr 1.0.8 is the most recent version listed at http://rubygems.org/gems/rsolr

jcoyne commented 11 years ago

@cbeer I'm concerned about this commit https://github.com/mwmitchell/rsolr/commit/e035079909cc744d32cded7568da07a958b17469 I'm not sure if that will affect blacklight.

jcoyne commented 11 years ago

Is there anything after 1.0.8 that we need? If not, I'm fine with locking to 1.0.8

jcoyne commented 11 years ago

1.0.9 has been released. https://rubygems.org/gems/rsolr/versions/1.0.9

jeremyf commented 11 years ago

@cbeer and I talked together about what all we should be locking. He would like to exclude rsolr, nom-xml, and nokogiri from the lock set.

I know @mark-dce has a compelling argument in the other direction. Thoughts?

jcoyne commented 11 years ago

It depends who the audience for this is. I'm thinking its for people who are new to ruby and in that case I think locking as many troublesome dependencies as possible would be a good idea. Why do you want to exclude rsolr, etc.

jeremyf commented 11 years ago

I will merge this as it is needed to fix the build. However, the larger discussion can continue.