search

samvera-deprecated / hydra

Project Hydra Stack Dependencies
Other
83 stars 30 forks source link

Formalizing pull request assignment #27

Closed jeremyf closed 10 years ago

cbeer commented 10 years ago

+1. Will leave open until the next call for comments.

mjgiarlo commented 10 years ago

Based on the earlier discussion on IRC, there are a few parts of this that need formalization:

  1. When PR is created, the submitter should be able to assign an owner.
  2. If a committer thinks that a PR needs to wait on her input, she should assign the ticket to herself, which is a way of saying, "Dear community, I need to do something before this is merged."
  3. When a committer is reviewing a PR for merging, she should check to see if there's an assigner already specified and, if so, consult with that person before merging it.

Is that overthinking things?

mjgiarlo commented 10 years ago

IMO, this is worth kicking around on hydra-tech a bit too.

jeremyf commented 10 years ago

@mjgiarlo Agreed

carolyncole commented 10 years ago

Seems reasonable, but what happens if a person is away/ sick? Things may stack up, which could be ok if that person is really required to review the PR. My guess is it can usually be a set of people though.

mjgiarlo commented 10 years ago

Hi @cam156: good question. I figure we can deal with that the same we do any other work that is not getting done: those who want the work done can nag via GitHub, hydra-tech, and committer calls. Or we pay @jcoyne to do it. ;)

dchandekstark commented 10 years ago

+0. I would like us to try out the proposed process first before updating the docs for all projects.

jeremyf commented 10 years ago

After a long conversation about this…not on this thread it was agreed that this was unnecessary.