search

samvera-deprecated / hydra

Project Hydra Stack Dependencies
Other
83 stars 30 forks source link

Put the install generator's code in clean env. #82

Closed bertrama closed 8 years ago

bertrama commented 8 years ago

The generate() methods in the install generator are failing when triggered in a rails application template. Putting them in Bundler.with_clean_env makes them work. This is a common practice, and examples of it can be found in Hydra::HeadGenerator.

mjgiarlo commented 8 years ago

Hi, @bertrama!

Thanks for the pull request. In order for us to merge this change, we'll need to have a signed Contributor License Agreement (CLA) on file for you as an individual. You can read more about our CLA processes here:

https://wiki.duraspace.org/display/hydra/Hydra+Project+Intellectual+Property+Licensing+and+Ownership

The process itself is fairly simple -- you just need to print out the Hydra Project individual CLA (iCLA) and sign it and then send it to legal@projecthydra.org. (I'm guessing @grosscol may be able to help since he has already been through this process.) Let me know if you have any questions about this process, and I'd be happy to help.

mjgiarlo commented 8 years ago

DO NOT MERGE until we have a CLA on file from @bertrama. Thanks, all.

bertrama commented 8 years ago

My iCLA has been sent, thanks!

mjgiarlo commented 8 years ago

@bertrama Your CLA has been processed. Thanks for contributing to Hydra!

:+1: