search

samvera-deprecated / jettywrapper

Convenience tasks and classes for automated testing of hydra heads.
Apache License 2.0
7 stars 19 forks source link

Only load rake tasks if rake DSL is present #31

Closed woods closed 10 years ago

woods commented 10 years ago

It's reasonably possible for Rake to be defined, but the DSL hasn't been included into the global namespace. If this is the case (such as happens when RubyMine runs tests within the IDE), then this line will blow up when jettywrapper gets required. Here we add an extra test to make sure that the required DSL is in place before we load the tasks.

woods commented 10 years ago

Never mind, this change is indeed breaking things on Travis. I can reproduce the problem on my machine. I'll reopen this pull request when I've figured it out.

woods commented 10 years ago

It turns out that we can fix this within our application by explicitly specifying rake in our Gemfile before jettywrapper.

I can also fix this issue by explicitly requiring rake in the list of require statements at the top of lib/jettywrapper.rb. But I'm not sure if that's appropriate for this gem -- it seems like not including the tasks is an option, since we're testing for whether Rake is defined.

Let me know if you'd like more information about the failure that we were getting from jettywrapper when running tests in RubyMine. Or feel free to leave this as closed if you think it's too much of an edge case to pursue.