samvera-deprecated / jettywrapper

Convenience tasks and classes for automated testing of hydra heads.
Apache License 2.0
7 stars 19 forks source link

update README #48

Closed ndushay closed 9 years ago

ndushay commented 9 years ago

I wrote two wiki pages, one about configuring jettywrapper and the other about using it.

I changed the README to

ndushay commented 9 years ago

I also wanted to drive home the point that folks can use blacklight-jetty when they only need Solr -- a lot of our developers use hydra-jetty when they don't need to.

mjgiarlo commented 9 years ago

I have two small requests (documented above). Great PR, thanks, @ndushay!

ndushay commented 9 years ago

So there is already a https://github.com/projecthydra/jettywrapper/blob/master/CONTRIBUTING.md in the project -- should it be updated to match https://github.com/projecthydra/hydra/blob/master/CONTRIBUTING.md ?

The latter refers to the hierarchy of promises ... is that still a thing?

ndushay commented 9 years ago

hrmm ... and doesn't this point to the notion that maybe there should be one contributing wiki or doc somewhere, rather than copied in each individual git repo??

awead commented 9 years ago

@ndushay I would leave the Contributing.md file alone for the time being. Yeah, we should probably do something to make them all the same, etc. or use a wiki page, but I think that's out of scope here. Could you squash your commits, and I'll be happy to merge this nice work you've done for us!

cbeer commented 9 years ago

We want a CONTRIBUTING.md file in each repository to trigger this behavior:

https://github.com/blog/1184-contributing-guidelines

(not to say they shouldn't be the same, though)

mjgiarlo commented 9 years ago

@ndushay @awead Re: keeping them all the same... we have a script in the Hydra repo for pushing out the central CONTRIBUTING.md to all repos in the projecthydra org. See here:

https://github.com/projecthydra/hydra/blob/master/script/push_contributing_document.rb

(We may want to add projecthydra-labs as well, but that's orthogonal to @ndushay's PR.)

mjgiarlo commented 9 years ago

I'm inclined to merge this PR and as a separate action encourage someone (?) to update the central CONTRIBUTING.md and distribute it via the above script. Thoughts? @cbeer @awead @ndushay

awead commented 9 years ago

@mjgiarlo :+1: unless you want the commits squashed... either way, I'm :ok:

mjgiarlo commented 9 years ago

Ah, yes, looking at the commit messages, a squash would be in order. Thanks, @awead.

ndushay commented 9 years ago

squashed. Huzzah!

mjgiarlo commented 9 years ago

Will merge as soon as Travis is :green_apple:

mjgiarlo commented 9 years ago

Thanks, @ndushay!