Closed ndushay closed 9 years ago
I also wanted to drive home the point that folks can use blacklight-jetty when they only need Solr -- a lot of our developers use hydra-jetty when they don't need to.
I have two small requests (documented above). Great PR, thanks, @ndushay!
So there is already a https://github.com/projecthydra/jettywrapper/blob/master/CONTRIBUTING.md in the project -- should it be updated to match https://github.com/projecthydra/hydra/blob/master/CONTRIBUTING.md ?
The latter refers to the hierarchy of promises ... is that still a thing?
hrmm ... and doesn't this point to the notion that maybe there should be one contributing wiki or doc somewhere, rather than copied in each individual git repo??
@ndushay I would leave the Contributing.md file alone for the time being. Yeah, we should probably do something to make them all the same, etc. or use a wiki page, but I think that's out of scope here. Could you squash your commits, and I'll be happy to merge this nice work you've done for us!
We want a CONTRIBUTING.md
file in each repository to trigger this behavior:
https://github.com/blog/1184-contributing-guidelines
(not to say they shouldn't be the same, though)
@ndushay @awead Re: keeping them all the same... we have a script in the Hydra repo for pushing out the central CONTRIBUTING.md to all repos in the projecthydra org. See here:
https://github.com/projecthydra/hydra/blob/master/script/push_contributing_document.rb
(We may want to add projecthydra-labs as well, but that's orthogonal to @ndushay's PR.)
I'm inclined to merge this PR and as a separate action encourage someone (?) to update the central CONTRIBUTING.md and distribute it via the above script. Thoughts? @cbeer @awead @ndushay
@mjgiarlo :+1: unless you want the commits squashed... either way, I'm :ok:
Ah, yes, looking at the commit messages, a squash would be in order. Thanks, @awead.
squashed. Huzzah!
Will merge as soon as Travis is :green_apple:
Thanks, @ndushay!
I wrote two wiki pages, one about configuring jettywrapper and the other about using it.
I changed the README to