search

samvera-deprecated / orcid

[DEPRECATED] A Rails engine for orcid.org integration.
https://github.com/projejcthydra-labs/orcid
Other
14 stars 7 forks source link

Introducing ProfileRequestCoordinator #33

Closed jeremyf closed 10 years ago

jeremyf commented 10 years ago

Responsible for converting an Orcid::ProfileRequest into an Orcid::Profile.

The Orcid::ProfileRequest object was doing too many things (i.e. persisting the profile request then handling the remote interaction with orcid.org).

I'm trying to tease apart the offline coordinator for the profile request. Basically separating the persistence of the initial request to processing that persisted request.

Also, this pull request includes adjusting Orcid exceptions inheritance.

I want to provide a base error from which Orcid errors are built from. That way, someone could feasibly rescue an Orcid::BaseError exception and handle in a uniform manner.

coveralls commented 10 years ago

Coverage Status

Coverage increased (+0.37%) when pulling cee51d1544eb55fa363d95519d5c77633ba6c216 on updating-profile-request-sequence into 3713ad1bb36012f96ed02598dd5285226caa1bba on master.

coveralls commented 10 years ago

Coverage Status

Coverage increased (+0.38%) when pulling e558b27c9466a93c00dab432eb788da896aa1b34 on updating-profile-request-sequence into 3713ad1bb36012f96ed02598dd5285226caa1bba on master.