samvera-deprecated / rdf-vocab

Shared RDF Vocabularies (rdf-vocab <= v0.7.0)
https://github.com/ruby-rdf/rdf-vocab
Apache License 2.0
4 stars 2 forks source link

regenerated MADS / MODS from the original OWL representations #11

Closed acoburn closed 9 years ago

acoburn commented 9 years ago

This produces a more complete class, including types, comments, labels, etc

jpstroop commented 9 years ago

I don't feel like I'm deep enough into MODS and MADS w/ RDF (or RDF.rb for that matter), to know what to say about this. Are the two versions functionally interchangeable?

dchandekstark commented 9 years ago

@acoburn I was thinking of adding the appropriate sections to the config file ... not that we can't merge this anyway.

dchandekstark commented 9 years ago

Also, FWIW I'm going to fix the rake task module to generate separate tasks for each vocab, so it's not all or nothing.

acoburn commented 9 years ago

the original MODS file included dateIssued, dateIssuedStart and dateIssuedEnd, which are not part of the spec (but which are referenced in the LC documentation). The new file does not include these predicates, since they are not part of the OWL representation. Also, if you want to make use of the subclassOf, domain and range attributes, those are also now present.

dchandekstark commented 9 years ago

@acoburn I've got the MODS and MADS uris and sources in the config, so ok with dropping this PR? I'll push mine up momentarily.

acoburn commented 9 years ago

@dchandekstark that works for me