search

samvera-deprecated / rdf-vocab

Shared RDF Vocabularies (rdf-vocab <= v0.7.0)
https://github.com/ruby-rdf/rdf-vocab
Apache License 2.0
4 stars 2 forks source link

Rename MARC_RELATORS? #18

Closed dchandekstark closed 9 years ago

dchandekstark commented 9 years ago

With respect to #9, should RDF::MARC_RELATORS be renamed to RDF::MARCRelators or RDF::MarcRelators?

/cc @jpstroop

jpstroop commented 9 years ago

I've tended to only use all caps for constants, and camel everything else, even when a segment of the phrase is an acronym. So RDF::MarcRelators, RDF::Mods etc. but that's just me--if there are more established conventions out there I'd happily yield to them.

dchandekstark commented 9 years ago

The uppercase with an underscore is I think where this name departs from common conventions. Even Ruby uses uppercase for some well-known acronyms like HTTP as in Net::HTTP. So, I'm not suggesting absolute consistency here -- I would keep RDF::MODS (or RDF::Vocab::MODS if/when we change the root namespace), etc. that we already have. @acoburn @no-reply @jcoyne ?

jpstroop commented 9 years ago

I tend to agree...for reasons I can't cite, MarcRelator doesn't bug me but Mods does. If you want to go all-uppercase for acronyms (MARCRelator), that's fine with me too. The code will still work :wink:.

dchandekstark commented 9 years ago

Alright, unless there a swift -1, let's call it MARCRelators.

acoburn commented 9 years ago

+1 on MARCRelators from me. Sorry for the delay -- no power and very limited internet access in Vermont today ;-(