search

samvera-deprecated / solrizer

A lightweight, configurable tool for indexing metadata into solr.
Apache License 2.0
30 stars 13 forks source link

Added date to default descriptors for backward compatibility #14

Closed dchandekstark closed 11 years ago

dchandekstark commented 11 years ago

Per recent discussion on hydra-tech about hydra-head 6.0.0 release and backward compatibility of solr_name.

dchandekstark commented 11 years ago

If this request is merged, please update active_fedora to use new version of solrizer.

jcoyne commented 11 years ago

I'm not certain that we want to maintain backward compatibility with this name. To me :dateable indicates that this is a macro which takes fields which are stored as strings, but we want indexed as dates, whereas :date is confusing, because it's a field type and used for many things. I think it's okay to break backwards compatibility since this is a major version release. I'd like to hear what others think, I'm open to being convinced.

dchandekstark commented 11 years ago

I agree that :date is confusing and should be phased out, and that it's OK to break backward compatibility here. My thought was to make the upgrade path easier for those who use solr_name instead of hard-coded field names, but perhaps it's not really such a good idea. I am happy to drop the PR if there is no interest or support.

dchandekstark commented 11 years ago

Issue dropped.