samvera-deprecated / solrizer

A lightweight, configurable tool for indexing metadata into solr.
Apache License 2.0
30 stars 13 forks source link

Use HTTPS URLs for RubyGems #31

Closed cokernel closed 10 years ago

cokernel commented 10 years ago

This modifies Gemfiles to use HTTPS URLs for RubyGems.

As a minor additional change, solrizer.gemspec now requires RSpec2, because the code

  RSpec::Core::RakeTask.new(:rspec) do |spec|
    spec.pattern = FileList['spec/**/*_spec.rb']
  end

does not function properly in RSpec3 (running rake yields the error "TypeError: no implicit conversion of Rake::FileList into String").

jcoyne commented 10 years ago

Looks good. @cokernel Do you have a CLA on file?

cokernel commented 10 years ago

@jcoyne, both I and my current institution (University of Kentucky) have CLAs on file.

cokernel commented 10 years ago

@jcoyne, it looks like the restriction to RSpec 2 can be avoided by replacing the Rake task above with

  RSpec::Core::RakeTask.new(:rspec) do |spec|
    spec.pattern = FileList['spec/**/*_spec.rb'].to_a
  end

This might be a little ugly, but it works in both RSpec 2 and RSpec 3.

Perhaps a simpler alternative is

  RSpec::Core::RakeTask.new(:rspec) do |spec|
    spec.pattern = 'spec/**/*_spec.rb'
  end

which also works in both versions of RSpec.