search

samvera-deprecated / solrizer

A lightweight, configurable tool for indexing metadata into solr.
Apache License 2.0
30 stars 13 forks source link

Adds deprecation warnings for the Module and the Class method Solrizer.solr_name #51

Closed jrgriffiniii closed 5 years ago

jrgriffiniii commented 5 years ago

Resolves #45

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.03%) to 97.581% when pulling ff71ab799a8bc15cb6588e4eaa78f44f9ef14020 on jrgriffiniii:issues-45-jrgriffiniii-deprecation into 6a53933cdc977a507342bbdde68a2165e3fd1263 on samvera:master.

jcoyne commented 5 years ago

This doesn't make sense to me. This is the primary feature of solrizer. Deprecating it's primary function seems wrong. Can you just stop using it if you don't need it?

tpendragon commented 5 years ago

I think I'm with @jcoyne here.

jrgriffiniii commented 5 years ago

It's deprecated (as in we discourage its use) in modern versions of Hyrax/HydraHead, but I still use it with my very old Hydra-Head (7.x) applications. I'd prefer not to see deprecation warnings there, because it's perfectly reasonable to use it in an old Hydra-head.

This is seems to be the consensus here.