search

samvera-deprecated / sufia

[DEPRECATED] Sufia: a fully featured, flexible Samvera repository front-end.
http://sufia.io/
Other
111 stars 78 forks source link

Rename FileSet URLs to match the Sufia URL aesthetic #1382

Closed mjgiarlo closed 7 years ago

mjgiarlo commented 8 years ago

From @mjgiarlo on November 18, 2015 22:58

Rather than /concern/file_sets/..., should be /concern/files/.... May require work in CurationConcerns to implement. (@jcoyne said so.)

@mjgiarlo should probably review all the routes in Sufia once the tests are passing and ticketize other such changes, before Sufia 7.0.0 ships.

Copied from original issue: projecthydra-labs/sufia-core#257

mjgiarlo commented 8 years ago

From @jcoyne on November 23, 2015 20:3

@mjgiarlo This change obfuscates the fact that the controller is dealing with FileSets and not PCDM::Files could cause confusion for developers working on Sufia in the future. Perhaps you can give your rationale for this request.

mjgiarlo commented 8 years ago

The rationale is simple but highly speculative: our users don't know what FileSets are but presumably know what files are. And I don't like underscores. ;) Your point is well taken about Sufia users that are PCDM-aware devs.

mjgiarlo commented 8 years ago

From @barmintor on December 2, 2015 20:43

What is the state of this ticket?

mjgiarlo commented 8 years ago

Still under discussion, @barmintor. Personally, I'd like to see this happen but perhaps given @jcoyne's point it's a lower priority?

awead commented 8 years ago

Related to #1424

mjgiarlo commented 7 years ago

I kinda don't care anymore.