samvera-deprecated / sufia

[DEPRECATED] Sufia: a fully featured, flexible Samvera repository front-end.
http://sufia.io/
Other
111 stars 78 forks source link

resolve predicate warnings #1693

Closed jcoyne closed 8 years ago

jcoyne commented 8 years ago

I'm seeing these warnings in the log:

Same predicate (http://purl.org/dc/elements/1.1/creator) used for properties file_author and creator
Same predicate (http://purl.org/dc/elements/1.1/language) used for properties file_language and language

we should figure out why this is happening and how to resolve it.

hectorcorrea commented 8 years ago

More information on this issue. The problem seems to be somewhere in FileSet.

Class FileSet is defined in .internal_test_app/app/models/file_set.rb as follows:

# Generated by curation_concerns:models:install
class FileSet < ActiveFedora::Base
  include ::CurationConcerns::FileSetBehavior
  include Sufia::FileSetBehavior
end

The warning is raised when Ruby processes include ::CurationConcerns::FileSetBehavior. I am still digging but wanted to update the ticket in case somebody has any ideas.

hectorcorrea commented 8 years ago

I think the root of the problem is that module CurationConcerns::FileSetBehavior includes CurationConcerns::BasicMetadata and Hydra::Works::Characterization::DocumentSchema and there is a property on each of these modules that uses the http://purl.org/dc/elements/1.1/creator predicate.

This is the line in which CurationConcerns::BasicMetadata defines a property that uses the DC:Creator predicate https://github.com/projecthydra-labs/curation_concerns/blob/master/app/models/concerns/curation_concerns/basic_metadata.rb#L18

This is the line in which Hydra::Works::Characterization::DocumentSchema defines property that uses the DC:Creator predicate: https://github.com/projecthydra-labs/hydra-works/blob/master/lib/hydra/works/characterization/schema/document_schema.rb#L4

mjgiarlo commented 8 years ago

:clap:

hectorcorrea commented 8 years ago

With https://github.com/projecthydra-labs/curation_concerns/pull/721 now merged this will be fixed once we get the next version of Curation Concerns.

mjgiarlo commented 8 years ago

:clap:

Closing.